DEV: Immediately send post for language detection for dual-text translations #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
reviewed
Feb 26, 2025
| def execute(args) | ||
| return unless SiteSetting.translator_enabled | ||
|
|
||
| translatable = args[:type].constantize.find_by(id: args[:translatable_id]) |
Contributor
There was a problem hiding this comment.
Should we validate that args[:type] returns a string?
tyb-talks
reviewed
Feb 26, 2025
| class AutomaticTranslations | ||
| def inject(plugin) | ||
| plugin.on(:post_process_cooked) do |_, post| | ||
| if SiteSetting.automatic_translation_target_languages.present? && post.user_id > 0 |
Contributor
There was a problem hiding this comment.
I'm missing some context on how auto-translation should work for system-type users like system (typically with negative user IDs), I'm assuming from these that they are deliberately exempt?
Contributor
Author
There was a problem hiding this comment.
Yes, for now, bot posts should not be translated. (so stuff like discobot PMs or AI bot responses should generally be avoided)
tyb-talks
approved these changes
Feb 26, 2025
Contributor
tyb-talks
left a comment
tyb-talks
left a comment
There was a problem hiding this comment.
lgtm outside of the nit on validating args[:type] :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not too long ago, we moved language detections to a scheduled job. (see internal /t/134867/21)
But the new inline translation feature (when turned on) sends all content for translation the moment it is created. So far, we are not seeing an issue with load for this.
This PR reverts the batching for language detection to the original way, in-line with the new translation feature.
This PR also does a bit of cleanup - introducing three files to encapsulate the plugin event hooks into their own functionality (automatic translation, inline translation, dual-text translation)
This changes here will help to simplify the problem of 🌐 showing up in the post briefly, but in a subsequent PR.