DEV: Simplify if-statements and test #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
commented
Feb 26, 2025
Comment on lines
-26
to
-30
| return false if post.locale_matches?(I18n.locale) | ||
| return false if post.translation_for(I18n.locale).present? | ||
| true | ||
| post.translation_for(I18n.locale).nil? | ||
| else | ||
| return false if post.locale_matches?(I18n.locale) |
Contributor
Author
There was a problem hiding this comment.
Basically the only real change is the common condition is brought up top.
tyb-talks
reviewed
Feb 26, 2025
| return false if post.locale_matches?(I18n.locale) | ||
| return false if post.translation_for(I18n.locale).present? | ||
| true | ||
| post.translation_for(I18n.locale).nil? |
Contributor
There was a problem hiding this comment.
was going to say .blank? is the direct complement of .present? but I guess there's enough safeguards against this being something like empty string? (I see the presence: true validation for translation)
tyb-talks
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor to prepare for a fix, so that the fix PR is less messy. Related comment here: #215 (comment)