UX: Remove flash of 🌐 when the post has yet to have its locale determined #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
added a commit
that referenced
this pull request
Apr 16, 2025
In #229 we added a buffer to not show the 🌐 within 10 seconds of post creation. We need to extend this to post edits as well to allow the edited post to be translated automatically and prevent the user from seeing the flash of 🌐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
Screen.Recording.2025-02-26.at.12.53.31.AM.mov
In the recording above, when a post is just created, we see the 🌐 appear for a brief moment, then disappear.
We typically want to show the 🌐 in case the post is not in the same language as the reader's. This works really well for old posts that do not have translation information. But since now all posts will be sent for locale detection on-create, it is a matter of seconds that the post's locale is determined.
This PR adds a buffer of 10 seconds that will prevent the 🌐 from appearing if 1. it was just created and 2. it doesn't have the locale yet.