FEATURE: Allow untranslated posts in inline-translation mode to be manually translated #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @service modal; | ||
| @service translator; | ||
| @service siteSettings; |
Contributor
There was a problem hiding this comment.
Did you mean to use this in showButton maybe? It's not used elsewhere in this file
Contributor
Author
There was a problem hiding this comment.
Yeah I had originally done some implementation in this file but removed it. Thanks!
| {{i18n | ||
| "translator.translated_from" | ||
| language=this.post.detectedLang | ||
| translator=this.siteSettings.translator |
Contributor
There was a problem hiding this comment.
Certainly a succinct setting name! :D I thought this was a mistake, I know you didn't add this and it's too late now anyway, but translator_provider or something would be better, it doesn't look like an actual setting ATM.
Contributor
Author
There was a problem hiding this comment.
I will likely rename the setting together with the "inline" thing we talked about.
Contributor
There was a problem hiding this comment.
Amazing, thank you!
martin-brennan
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the 🌐 only appears in dual-text mode (not inline translation mode) when the
experimental_topic_translationfeature is disabled. This means we are unable to translate old posts when inexperimental_topic_translation.This PR allows 🌐 to show up when
experimental_topic_translationis enabled, and does not show the dual-text translation below (the old method) but replaces the content inline instead.In addition in this PR, when
experimental_topic_translationis enabled, it takes the response from /translate and updates the post cooked and topic title for inline replacement. (in other scenarios, translation updates are done by messagebus)(also backfills many untested js files)
Videos to indicate how function works with this PR:
Parallel
parallel.mp4
Inline
inline.mp4
(This isn't really a FIX since it was never a real feature...)