FIX: 'Show original' button only shows in topics where there are translated content #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
commented
Mar 5, 2025
Comment on lines
+33
to
+35
| locale = DiscourseTranslator::InlineTranslation.effective_locale | ||
| return false if post.locale_matches?(locale) | ||
| post.translation_for(locale).nil? |
Contributor
Author
There was a problem hiding this comment.
When in experimental_inline_translation, we only want to allow a user to translate a post if the user's locale is within the target languages that we support for the site (effective_locale).
nattsw
commented
Mar 5, 2025
Comment on lines
+14
to
+16
| # since locales are eager loaded but translations may not, | ||
| # always return early if topic and posts are in the user's effective_locale. | ||
| # this prevents the need to load translations. |
Contributor
Author
There was a problem hiding this comment.
All plugin api usages will check for locale first.
nattsw
commented
Mar 5, 2025
Comment on lines
+57
to
+67
| plugin.add_to_serializer(:basic_post, :is_translated) do | ||
| SiteSetting.experimental_inline_translation && | ||
| !object.locale_matches?(InlineTranslation.effective_locale) && | ||
| object.translation_for(InlineTranslation.effective_locale).present? | ||
| end | ||
|
|
||
| plugin.add_to_serializer(:topic_view, :is_translated) do | ||
| SiteSetting.experimental_inline_translation && | ||
| !object.topic.locale_matches?(InlineTranslation.effective_locale) && | ||
| object.topic.translation_for(InlineTranslation.effective_locale).present? | ||
| end |
Contributor
Author
There was a problem hiding this comment.
These two flags are used in the frontend to check if a topic is showing translated content
brrusselburg
reviewed
Mar 5, 2025
| end | ||
|
|
||
| def self.user_locale_is_default? | ||
| # e.g. :en_UK vs "en_UK" |
brrusselburg
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the button above shows up even when there are no posts translated. With this PR, we will not show the button if there are zero posts in the topic that is translated.
This PR also
SiteSetting.automatic_translation_target_languages)