DEV: Backfill per locale per model instead of just per model #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfalcox
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently backfilling very inefficiently, as we were querying by a single Topic or Post as long as it does not have any of the target languages (based on an array rather than a single locale).
This PR splits the backfill job into per locale rather than grouping all the locales together and finding which topics have missing translations. e.g. from the log item below, you can sort of tell that 18 topics are "shared" between all the languages, even if the language already has the translation.
It does potentially end up loading a topic multiple times, but the alternative is a much slower backfill if new languages get added to the target languages.