DEV: Move saving translations outside of the API providers #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
commented
Mar 6, 2025
Comment on lines
-111
to
+120
| save_detected_locale(topic_or_post) do | ||
| begin | ||
| client.translate_text( | ||
| { | ||
| text: truncate(text_for_detection(topic_or_post)), | ||
| source_language_code: "auto", | ||
| target_language_code: SUPPORTED_LANG_MAPPING[I18n.locale], | ||
| }, | ||
| )&.source_language_code | ||
| rescue Aws::Errors::MissingCredentialsError | ||
| raise I18n.t("translator.amazon.invalid_credentials") | ||
| end | ||
| begin | ||
| client.translate_text( | ||
| { | ||
| text: truncate(text_for_detection(topic_or_post)), | ||
| source_language_code: "auto", | ||
| target_language_code: SUPPORTED_LANG_MAPPING[I18n.locale], | ||
| }, | ||
| )&.source_language_code | ||
| rescue Aws::Errors::MissingCredentialsError | ||
| raise I18n.t("translator.amazon.invalid_credentials") |
Contributor
Author
There was a problem hiding this comment.
Bulk of the change is just removing save_... out of the providers.
xfalcox
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, each translation provider has been saving translation as part of doing the translation.
We are moving the saving outside of the providers, so
detect!andtranslate!only does the detection and translation. Saving is now done in the base class so any future changes do not have to involve each translator.This PR is to prepare / reduce complexity for the subsequent PR where we move to using raw to translate instead of cooked.