FIX: Revert translating raw for translator providers as they strip newlines #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixing tests |
dbattersby
reviewed
Mar 12, 2025
| text_for_translation(translatable, raw: true), | ||
| target_locale_sym, | ||
| ).translate | ||
| DiscourseTranslator::TranslatedContentNormalizer.normalize(translatable, translated) |
There was a problem hiding this comment.
Normalizing will cook the response using PrettyText when it's a Post, but not topics from what I understand. Would there ever be a case when the topic title has HTML I wonder?
Contributor
Author
There was a problem hiding this comment.
Good question:
The normalizer™ takes the post/topic and its translation, and applies cook if it is a post, and applies cleanup if it is a topic. Technically speaking the topic title can contain html but the case has been covered here: #224
Contributor
Author
|
Thank you @dbattersby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6c197c5, we changed to translate raw instead of cooked. This was largely due to DiscourseAI.
However some tests have shown that the original decision of translating cooked is likely due to translation providers like Google or Azure (and the rest) stripping newlines when translating. However these translator providers keep html as-is, so translating cooked is reasonable.
This PR reverts the other providers to use cooked, but keeps DiscourseAI as the only provider using raw.
The following is a trivial example, but in some more complex cases, the absence of certain characters (besides newline) removed by the provider when dealing with raw is a bit more jarring.
Original post written in Japanese (2img 2para)
Post translated using raw (Google)
Post translated using cooked (Google)