DEV: Use cookie instead of URL param to show original content #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
force-pushed
the
show-original-w-
branch
from
aafb500 to
84323cc
Compare
Member
|
To avoid cache poisoning, this cookie will need to be added to the AnonymousCache middleware key. (I think there's a plugin API for that?) |
nattsw
requested review from
davidtaylorhq
and removed request for
davidtaylorhq
| } | ||
| window.location.search = params.toString(); | ||
|
|
||
| window.location.reload(); |
Member
There was a problem hiding this comment.
Random thought... would calling .refresh() on the Ember router service be enough here? In theory that should re-run all model() hooks on routes? Might be a smoother experience than a full page reload?
Contributor
Author
There was a problem hiding this comment.
You are right - weirdly, I included the router already but hadn't called refresh. This is a much better experience ✨
davidtaylorhq
approved these changes
Apr 11, 2025
nattsw
added a commit
to discourse/discourse
that referenced
this pull request
May 8, 2025
As we move content localization to core, we will need to register a new key to handle cases when anon users hit the cache to avoid cache poisoning. Related: - discourse/discourse-translator#273 - https://github.com/discourse/discourse-translator/blob/d7ae61198185705a3e03c14b2ce5a01dffbb1be2/lib/discourse_translator/inline_translation.rb#L94-L98
martin-brennan
pushed a commit
to discourse/discourse
that referenced
this pull request
Jun 10, 2025
As we move content localization to core, we will need to register a new key to handle cases when anon users hit the cache to avoid cache poisoning. Related: - discourse/discourse-translator#273 - https://github.com/discourse/discourse-translator/blob/d7ae61198185705a3e03c14b2ce5a01dffbb1be2/lib/discourse_translator/inline_translation.rb#L94-L98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the "Show Original" button on the right side of the page is clicked, we append the param
?show=originaland trigger a refresh to show the original user-written post content.With this PR, we will be using cookies (
discourse-translator-show-original) instead. This cookie is applied site-wide, not per-topic.