FEATURE: Show an indicator for posts not originally written in the user's language #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
commented
Apr 14, 2025
Comment on lines
+13
to
+17
| <DTooltip | ||
| @identifier="discourse-translator_translated-post-indicator" | ||
| @icon="language" | ||
| @content={{this.tooltip}} | ||
| /> |
Contributor
Author
There was a problem hiding this comment.
I had considered just using {{icon "language" title="something"}} but it looks like the title will always be i18n-ified.
nattsw
added a commit
to discourse/discourse
that referenced
this pull request
May 15, 2025
Related: - discourse/discourse-translator#205 - discourse/discourse-translator#274 - discourse/discourse-translator#294 With this PR, we will start showing localized posts (if available) based on the user's locale. This work had been done in discourse-translator, but is now moving to core.
martin-brennan
pushed a commit
to discourse/discourse
that referenced
this pull request
Jun 10, 2025
Related: - discourse/discourse-translator#205 - discourse/discourse-translator#274 - discourse/discourse-translator#294 With this PR, we will start showing localized posts (if available) based on the user's locale. This work had been done in discourse-translator, but is now moving to core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a little indicator in each post that shares the original post language. It only shows up when
experimental_inline_translationis enabled, and if the post's language is not matching the user's locale.Reviewer note: We're currently using the LocaleSiteSetting values to determine the name of the language, so we will get values like "Español" instead of "Spanish". In the future we will consider localized language names (internal /151409)