FEATURE: Translate categories with selected provider #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lis2
reviewed
Apr 23, 2025
| translated_name = translator.translate_text!(category.name, target_locale_sym) | ||
| translated_description = translator.translate_text!(category.description, target_locale_sym) | ||
|
|
||
| category.update!(name: translated_name, description: translated_description) |
Contributor
There was a problem hiding this comment.
My understanding is that in a job we loop through locale, translate and then update name and description column. So if we have SiteSetting.automatic_translation_target_languages = "en|pl|de", only last locale translation will be saved.
Is it expected?
Contributor
Author
There was a problem hiding this comment.
My understanding is that in a job we loop through locale
In the job it loops category and locale:
categories.each do |category|
locales.each do |locale|
# invoke this translation method
end
end
Then this .translate method translates for the specific category and locale.
nattsw
commented
Apr 23, 2025
pmusaraj
approved these changes
Apr 23, 2025
This was referenced Apr 24, 2025
nattsw
added a commit
that referenced
this pull request
Apr 30, 2025
Earlier on in #282 we introduced a setting for categories only. That is quite short-sighted so the setting is now for all user generated content `experimental_content_translation`. This will be used in the next commit that translates posts and topics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature introduces the ability to translate categories on core's CategoryLocalization from discourse/discourse#32380. This includes
Translator.translatewhich takes in supported modelsCategoryTranslatorspecific to categories, which uses the basic text translator introduced in DEV: Add the ability to translate a single piece of text #281Anyone can manually translate all categories using