Skip to content

DEV: generate only en_us locales #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2024
Merged

DEV: generate only en_us locales #855

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a18035
DEV: generate only en_us locales
featheredtoast Aug 31, 2024
983a566
DEV: remove unused c and non-utf8 en_US locales
featheredtoast Oct 14, 2024
7660fb0
DEV: remove locale.gen, add entry to list
featheredtoast Oct 14, 2024
2f30477
DEV: uncomment existing locale rather than echo new one.
featheredtoast Oct 14, 2024
21f3e8a
FIX: actually use -i option on sed to edit files
featheredtoast Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions image/base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@ RUN sh -c "fping proxy && echo 'Acquire { Retries \"0\"; HTTP { Proxy \"http://p
RUN apt-mark hold initscripts
RUN apt-get -y upgrade

RUN DEBIAN_FRONTEND=noninteractive apt-get install -y locales locales-all
RUN DEBIAN_FRONTEND=noninteractive apt-get install -y locales
ENV LC_ALL en_US.UTF-8
ENV LANG en_US.UTF-8
ENV LANGUAGE en_US.UTF-8
ADD locale.gen /etc/locale.gen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should maintain a giant list of locales since we need to keep what is uncommented in the list in-sync with the LC_ALL, LANG and LANGUAGE ENVs. I think we should just do something like echo 'en_US.UTF-8 UTF-8' >> /etc/locale.gen which is what the official postgres docker image do.

RUN locale-gen

RUN install -d /usr/share/postgresql-common/pgdg &&\
curl -o /usr/share/postgresql-common/pgdg/apt.postgresql.org.asc --fail https://www.postgresql.org/media/keys/ACCC4CF8.asc &&\
Expand Down Expand Up @@ -66,7 +68,6 @@ RUN cd / &&\
mkdir -p /etc/runit/1.d &&\
apt-get clean &&\
rm -f /etc/apt/apt.conf.d/40proxy &&\
locale-gen en_US &&\
DEBIAN_FRONTEND=noninteractive apt-get install -y nodejs yarn &&\
npm install -g terser uglify-js pnpm

Expand Down
Loading
Loading