DEV: parameterize config filename #872
Conversation
depends on discourse/discourse_docker#872 to be merged first for parameterization
Parameterize the config filename for writing config to and expected file to be copied from in resulting dockerfiles
featheredtoast
force-pushed
the
parameterize-config-filename
branch
from
8e2fc4c to
16480ce
Compare
|
@featheredtoast Just from the PR description, I can't deduce why this change is required. Will you be able to update the PR description to reflect the "why"? Thank you 🙇 |
|
@tgxworld this one allows for external tools to parameterize where the config.yaml file gets written to, and picked up in a dockerfile, rather than being hardcoded as I've got a proof-of-concept write-config-to-docker-compose that could take advantage of this, that allows an export of a 2-container setup to a docker-compose. Without it, I realized there isn't a good way to do something like print multiple config.yaml config files and their dockerfiles to the same location. Experimental branch here takes advantage of this: featheredtoast/discourse-launcher-extras@33d98b2 |
|
reopened here discourse/launcher#2 |
Parameterize which filename to write to (write config) and which file is copied from (dockerfile)