Show users an SMTP protocol configuration option, preset based on the given port #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d with TLS for port 465, STARTTLS otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows my post on the meta.discourse forum about setting up the email for port 465.
I added a prompt for "SMTP protocol" to the setup.
It's prefilled with
TLSif the chosen port is 465, otherwiseSTARTTLS. WhenTLSis chosen, it actually means "implicit TLS".In the resulting
app.ymlfile, this will set bothDISCOURSE_SMTP_ENABLE_START_TLSandDISCOURSE_SMTP_FORCE_TLSaccordingly.It might be best to replace these two configuration variables with a single one, e.g.
DISCOURSE_SMTP_PROTOCOL, but I cannot handle that at the moment because my knowledge of the source code is limited to the setup script.This pull request is just a suggestion!
Also: there is an additional commit that fixes an error in the definition of
read_default. Let me know if I should do a separate PR for that.Cheers,