DEV: separate builders #882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim image by building nginx and imagemagick separately build jhead from source with no dependencies remove optipng, and pngcrush as these are disabled workers in discourse image_optim separate out discourse_web and discourse_release for no database web-only images. minimize layers by merging RUN commands prefer `&&\;` over `;\` for failing early on failing commands
|
will re-open this work in chunks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slim image by building nginx and imagemagick separately. Copy results to final image.
build jhead from source with no dependencies
remove optipng, and pngcrush as these are disabled workers in discourse image_optim
separate out discourse_web and discourse_release for no database web-only images.
minimize layers by merging RUN commands
prefer
&&\;over;\for failing early on failing commandsRe-orders targets to:
discourse_dependencies (install all common dependencies)
discourse_slim (clone discourse)
discourse_web (bundle install)
discourse_release (install redis+postgres)
Allows for us to target another image as discourse_web to remove postgres+redis from the image. Drops compressed size of slim to 494.22MB.