DEV: slim image by dropping building jhead from source, and dropping optipng #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optipng jhead from apt pulls in a ton of packages, and optipng isn't used
|
How much do we save by compiling jhead ourselves? |
|
This change is 8MB compressed. It'd be very nice to have a github action be able to report this for us at some point. |
|
main: 648.38MB |
tgxworld
approved these changes
Nov 7, 2024
tgxworld
reviewed
Nov 7, 2024
|
|
||
| # Install other deps | ||
| apt -y -q install advancecomp jhead jpegoptim libjpeg-turbo-progs optipng | ||
| apt -y -q install advancecomp jpegoptim libjpeg-turbo-progs |
There was a problem hiding this comment.
Not really related to this PR but I did wonder why we are installing various jpeg packages in the install-oxipng script which I would think should only deal with oxipng.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jhead from apt pulls in a ton of packages, and optipng isn't used