Remove git reset --hard command in web template to reduce layer size
#903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that use running `git reset --hard` results in ~133MB being added to the final layer generated by `launcher bootstrap`. However, I can not figure out why we would need to run `git reset --hard` at all. Even if there is a reason to run `git reset --hard`, it should not be the default. If someone for whatever reason needs to run `git reset --hard`, they should do so using the `before_code` hook.
CvX
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that use running
git reset --hardresults in ~133MB beingadded to the final layer generated by
launcher bootstrap. However, Ican not figure out why we would need to run
git reset --hardat all.Even if there is a reason to run
git reset --hard, it should not bethe default. If someone for whatever reason needs to run
git reset --hard, they should do so using thebefore_codehook.To replicate the problem, one can run the following steps:
discourse_dockerrepository, create a file namedcontainers/test.ymlwith the following contents:./launcher bootstrap testdocker history local_discourse/testand see that the new layer created by./launcher bootstrapis roughly 133MB.