Skip to content

Revert "Use Nginx config with outlets (#913)" #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Revert "Use Nginx config with outlets (#913)" #958

merged 1 commit into from
May 9, 2025

Conversation

@tgxworld
Copy link
Contributor

@tgxworld tgxworld commented May 9, 2025

This reverts commit 7b042d6.

web.socketed.template.yml is broken

@tgxworld
Revert "Use Nginx config with outlets (#913)"
ab6db99 
This reverts commit 7b042d6.

`web.socketed.template.yml` is broken
@tgxworld
Copy link
Contributor Author

tgxworld commented May 9, 2025

Meta context in https://meta.discourse.org/t/cannot-rebuild-app-after-recent-upgrade-05-07-2025/365213

@tgxworld tgxworld merged commit 3c22348 into main May 9, 2025
3 checks passed
@tgxworld tgxworld deleted the revert_broken_changes branch May 9, 2025 03:09
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/cannot-rebuild-app-after-recent-upgrade-05-07-2025/365213/15

nbianca added a commit that referenced this pull request May 9, 2025
@nbianca
Reapply "Use Nginx config with outlets (#913)" (#958)
d5792cd 
This reverts commit 3c22348.
nbianca added a commit that referenced this pull request May 19, 2025
@nbianca
Use Nginx config outlets in templates (#959)
47506fd 
* Reapply "Use Nginx config with outlets (#913)" (#958)

This reverts commit 3c22348.

* Keep empty outlet files instead of removing them

This is necessary because `replace` operation checks if file exists
first. This is a fix for socketed template.

* Create placeholders for all templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamSaffron SamSaffron SamSaffron approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tgxworld @discoursebot @SamSaffron