Use Nginx config outlets in templates #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because `replace` operation checks if file exists first. This is a fix for socketed template.
tgxworld
reviewed
May 9, 2025
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/cannot-rebuild-app-after-recent-upgrade-05-07-2025/365213/16 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/daily-summary-1pm-utc/291852/471 |
|
Here is an alternative approach to apply related replacements via web and ssl hooks: #957 |
tgxworld
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reapplies commit 3c22348 with a fix to keep outlet files instead of removing them so
replacecontinues to work.