Skip to content

Provide instructions for removing bundled plugin clone config #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Provide instructions for removing bundled plugin clone config #974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions launcher
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ usage () {
exit 1
}

BUNDLED_PLUGINS=(
"discourse-reactions"
)

# for potential re-exec later
SAVED_ARGV=("$@")

Expand Down Expand Up @@ -481,6 +485,20 @@ RUBY
merge_user_args
}

# Temporary helper to provide a more useful error message when a bundled plugin is still referenced in the config file.
explain_bundled_plugin_error() {
config_data=$(cat $config_file)
for plugin in "${BUNDLED_PLUGINS[@]}"; do
if [[ $config_data =~ "git clone https://github.com/discourse/$plugin" ]]; then
echo "---"
echo "HINT: The plugin '$plugin' is now bundled with Discourse and should not be included in your container configuration."
echo "Remove the line 'git clone https://github.com/discourse/$plugin' from your $config_file file, then try again."
echo "For more information, see https://meta.discourse.org/t/373574"
echo "---"
fi
done
}

if [ -z $docker_path ]; then
install_docker
fi
Expand Down Expand Up @@ -706,6 +724,7 @@ run_bootstrap() {
exit 77
elif [[ $BOOTSTRAP_EXITCODE -gt 0 ]]; then
echo "bootstrap failed with exit code $BOOTSTRAP_EXITCODE"
explain_bundled_plugin_error
echo "** FAILED TO BOOTSTRAP ** please scroll up and look for earlier error messages, there may be more than one."
echo "./discourse-doctor may help diagnose the problem."

Expand Down