FIX: improve postgres upgrade reliability #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems the /shared/postgres_data directory might be a mount point, so in order to avoid failure in this scenario, move the postgres data files directly instead of manipulating the data directory. see https://meta.discourse.org/t/infinite-loop-during-postgres-upgrade/91767/8?u=lavamind
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/infinite-loop-during-postgres-upgrade/91767/9 |
|
@Supermathie @fitzy101 This looks OK to me but can you also review it please before I merge? Thank you! |
tgxworld
approved these changes
Jul 31, 2025
Looks OK to me too. |
fitzy101
approved these changes
Jul 31, 2025
|
Thank you @jcharaoui 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems the /shared/postgres_data directory might be a mount point, so in order to avoid failure in this scenario, move the postgres data files directly instead of manipulating the data directory.
see https://meta.discourse.org/t/infinite-loop-during-postgres-upgrade/91767/8?u=lavamind