Skip to content

Commit b761ecb

Browse files
committed
empty? changed to length.zero? to respect expiry
1 parent f8d7777 commit b761ecb

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

lib/prometheus_exporter/server/good_job_collector.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def type
2323
end
2424

2525
def metrics
26-
return [] if good_job_metrics.empty?
26+
return [] if good_job_metrics.length.zero?
2727

2828
good_job_metrics.each(&method(:process_metric))
2929
gauges.values

lib/prometheus_exporter/server/metrics_container.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
module PrometheusExporter::Server
44
class MetricsContainer
5+
# Since MetricsContainer defines #each, we can include Enumerable
6+
include Enumerable
57
METRIC_MAX_AGE = 60
68
METRIC_EXPIRE_ATTR = "_expire_at"
79

@@ -34,10 +36,6 @@ def size(&blk)
3436
end
3537
alias_method :length, :size
3638

37-
def map(&blk)
38-
wrap_expire(:map, &blk)
39-
end
40-
4139
def each(&blk)
4240
wrap_expire(:each, &blk)
4341
end

0 commit comments

Comments
 (0)