refactor: Move yaml data into workspace package#855
Closed
marcustyphoon wants to merge 1 commit intomainfrom
Closed
refactor: Move yaml data into workspace package#855marcustyphoon wants to merge 1 commit intomainfrom
marcustyphoon wants to merge 1 commit intomainfrom
Conversation
c60d9f5 to
2827702
Compare
Contributor
|
Deployed preview build to Cloudflare!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of experimentation with PNPM workspaces. This moves the yaml data into its own workspace package.
I concluded that this isn't as useful as one might think, as:
It's thus not really elegant to publish a subpackage on npm/jsr, and the only point of using a workspace package instead of a subfolder is to get namespaced imports instead of path imports. Who cares?
This was pretty informative, though; the actual thing that could be useful is splitting this repo into a calculation package that can be embedded on a different website and an optimizer.discretize.eu package (i.e. for discretize/discretize.eu-rewrite#36). It would be a quite large amount of moving files around, though, and the redux store files really contain most of the types required to feed meaningful data into what would be the calculation package, so it really isn't that useful either.
[draft previews]