chore: use separate struct for Invite roles#522
Open
yokkkoso wants to merge 2 commits intodisgoorg:masterfrom
Open
chore: use separate struct for Invite roles#522yokkkoso wants to merge 2 commits intodisgoorg:masterfrom
yokkkoso wants to merge 2 commits intodisgoorg:masterfrom
Conversation
topi314
requested changes
Feb 24, 2026
Member
topi314
left a comment
There was a problem hiding this comment.
looks good, can you also add the same base methods as the normal role struct?
- String
- Mention
- IconURL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use separate struct for Invite roles because as docs says:
And currently, using the default Role sturct results in a unmarshalling error when performing a GET /invites/INVITE_CODE request: