Improve ADT validators' performance#1573
Merged
kubukoz merged 13 commits intoseries/0.18from Mar 11, 2025
Merged
Conversation
1873b60 to
840e8cf
Compare
Member
Author
|
So far, so good -
Baseline: #1319 (comment) |
…there's at least one structure target)
Member
Author
kubukoz
commented
Mar 6, 2025
modules/protocol-tests/test/src/smithy4s/api/validation/AdtMemberTraitValidatorSpec.scala
Outdated
Show resolved
Hide resolved
Baccata
reviewed
Mar 7, 2025
modules/protocol/src/smithy4s/meta/validation/AdtTraitValidator.java
Outdated
Show resolved
Hide resolved
Baccata
reviewed
Mar 7, 2025
modules/protocol/src/smithy4s/meta/validation/AdtTraitValidator.java
Outdated
Show resolved
Hide resolved
kubukoz
commented
Mar 10, 2025
Baccata
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #1319. Also actually prevents ADTs from being mixins, which shouldn't have been possible in the first place.
Tested on a model with 92k shapes (including 78k members) using 288
@adtMembers and 33@adts.Before: 11+ seconds
The original implementation was spending most its time in the
getReferencesmethod:which had linear time complexity on the number of member shapes in the model, which let's be honest - are the most common type of shape by far in any realistic model.
After: <200ms
In the new implementation, there's no sharing of code (the validation patterns are different, so I didn't think it's worth sharing), and we utilize things like
getShapesWithTraitand selectors to get better perf. Probably linear in the number of shapes annotated with each of the ADT traits.PR Checklist (not all items are relevant to all PRs)