feat: Add support for flexible defaults encoding#1652

Merged

kubukoz merged 44 commits intodisneystreaming:series/0.18from

ghostbuster91:feat/flexible-defaults

Mar 12, 2025

Contributor

ghostbuster91 commented Feb 20, 2025 •

edited

Loading

PR Checklist (not all items are relevant to all PRs)

Added unit-tests (for runtime code)
~~Added bootstrapped code + smoke tests (when the rendering logic is modified)~~ N/A
~~Added build-plugins integration tests (when reflection loading is required at codegen-time)~~ N/A
~~Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)~~ N/A
~~Updated dynamic module to match generated-code behaviour~~ N/A
Added documentation
Updated changelog

Refers to #1398

ghostbuster91 added 4 commits

February 20, 2025 11:10


          feat: Add support for more flexible defaults encoding

ce6ef09


          Flip the condition

4988b75


          Add skipIfEmptyCollection variants

ea94e00


          tweaks for @deprecated annotation

86ec35a

ghostbuster91 commented

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

ghostbuster91 commented

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

ghostbuster91 commented

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

ghostbuster91 commented

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

ghostbuster91 commented

View reviewed changes

modules/core/src/smithy4s/internals/DocumentEncoderSchemaVisitor.scala Show resolved Hide resolved

Contributor Author

ghostbuster91 commented Feb 20, 2025

I am not happy about the implementation of SkipIfEmptyCollection so I am fine with dropping it at this stage to minimize the amount of changes, but wanted to showcase it in case you think that it is worth to have something like that.


          Add empty line after header

ad50e81

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldRenderPredicateCompiler.scala Outdated Show resolved Hide resolved

Contributor

Baccata commented Feb 21, 2025

A good start 👍

Contributor Author

ghostbuster91 commented Feb 21, 2025

@kubukoz wanna have a look?

ghostbuster91 added 9 commits

February 22, 2025 11:05


          Apply review comments

56a4f8c


          Rename to FieldSkipCompiler

a2a2ea5


          Mark explicitDefaultsEncoding as deprecated

09726d9


          Create monoid instance for FieldSkipCompiler

7e61abe


          Fix compilation for scala3

2b99a25


          Fix bijection and refinement

dbb6026


          Rewrite tests and convert FieldSkipCompiler instances to case objects

030ebf7


          Add lazy implementation

04a4ae6


          Add test for recursive list

0a18cad

ghostbuster91 commented

View reviewed changes

modules/core/src/smithy4s/codecs/FieldSkipCompiler.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldFilter.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldFilter.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldFilter.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldFilter.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldFilter.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldFilter.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/docs/markdown/03-protocols/04-simple-rest-json/01-overview.md Show resolved Hide resolved

ghostbuster91 and others added 5 commits

February 26, 2025 22:26


          Rename compileOptional to compileNonRequired

a01cd4f


          Rename SkipUnsetAndDefaultOptionValues to Default

fe46b86


          Merge remote-tracking branch 'origin/series/0.18' into feat/flexible-…

819b71d

…defaults


          Fix compilation and add test case for bijection schema

8c12a29


          Merge branch 'series/0.18' into feat/flexible-defaults

288af6a

ghostbuster91 force-pushed the feat/flexible-defaults branch from 61e124e to 288af6a Compare

March 7, 2025 16:15

ghostbuster91 added 2 commits

March 7, 2025 18:17


          Add test for refined schema

22d1b31


          Update docs

12e4efd

kubukoz approved these changes

View reviewed changes

Member

kubukoz left a comment

@Baccata please have a final look too


          Merge branch 'series/0.18' into feat/flexible-defaults

82b3b2b

Baccata reviewed

View reviewed changes

modules/core/src/smithy4s/codecs/FieldFilter.scala Outdated Show resolved Hide resolved

Baccata reviewed

View reviewed changes

modules/bootstrapped/test/src/smithy4s/DocumentSpec.scala Outdated Show resolved Hide resolved

Contributor

Baccata commented Mar 12, 2025

Good work. Just a couple nitpicks (and also this : #1652 (comment))

ghostbuster91 added 3 commits

March 12, 2025 12:23


          Move FieldFilter to smithy4s.schema

87b3d32


          Fix typo

25f4705


          Rename SkipDefaultOptionValues to SkipNonRequiredDefaultValues

8fd45b7

Baccata approved these changes

View reviewed changes

ghostbuster91 added 2 commits

March 12, 2025 15:01


          Add missing changelog entry

2b9c972


          Remove redundant imports after refactor

kubukoz merged commit 1c1e16d into disneystreaming:series/0.18

11 checks passed

ghostbuster91 deleted the feat/flexible-defaults branch

March 12, 2025 18:42

kubukoz mentioned this pull request

Support more flexible explicit defaults #1398

Closed

Member

kubukoz commented Mar 21, 2025

@ghostbuster91 fyi if you said "Closes #1398" merging this would've closed the ticket, worth remembering in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet