Use the inputs when testing URI conversions in Http4sConversionSpec#1666
Conversation
|
|
1 similar comment
|
|
|
|
||
| http4sToSmithyAndBackUriTest( | ||
| uri"example.com", | ||
| uri"//example.com", |
There was a problem hiding this comment.
Without the leading //, http4s parses this as the URI path, so the test fails because it was essentially trying to compare http://localhost/example.com to http://example.com.
There was a problem hiding this comment.
i've had the "pleasure" of hitting this... yeah it's fun
|
pretty sure the CLA isn't needed for a change like this |
Not a huge deal, but I discovered that
Http4sConversionSpec#http4sToSmithyAndBackUriTestwasn't using its input in its test setup, so most of the tests were redundant. I believe this was the intended test behavior.