Improve handling of @default(null) and @nullable#1667
Merged
kubukoz merged 21 commits intodisneystreaming:series/0.19from Apr 14, 2025
Merged
Improve handling of @default(null) and @nullable#1667kubukoz merged 21 commits intodisneystreaming:series/0.19from
@default(null) and @nullable#1667kubukoz merged 21 commits intodisneystreaming:series/0.19from
Conversation
ghostbuster91
changed the title
@default(null) and @nullable
Member
|
dunno why now, but it looks like we got upgraded to the ubuntu 24.04 runners which don't have sbt, gonna have to install it manually now. https://github.com/neandertech/langoustine/pull/199/files#r2008968475 |
ghostbuster91
force-pushed
the
feat/null-defaults
branch
from
0438bb4 to
947d252
Compare
ghostbuster91
commented
Apr 9, 2025
| nullDefault <- List(true, false) | ||
| } yield { | ||
| test( | ||
| s"combinations of required, nullable, and null default ($required, $nullable, $nullDefault)" |
Contributor
Author
There was a problem hiding this comment.
note this way it is clear when something fails which case is that.
Contributor
|
@ghostbuster91, this ready for review ? |
Contributor
Author
Yes |
Baccata
reviewed
Apr 10, 2025
Contributor
|
Good work ! Just would like to take advantage of you making changes to this space to add tests to the |
ghostbuster91
commented
Apr 11, 2025
Baccata
approved these changes
Apr 11, 2025
kubukoz
approved these changes
Apr 11, 2025
Member
|
See you in the release 😭 |
kubukoz
reviewed
Apr 14, 2025
Member
kubukoz
left a comment
kubukoz
left a comment
There was a problem hiding this comment.
forgor, the docs need updating - https://disneystreaming.github.io/smithy4s/docs/codegen/default-values#null-default
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)
This closes #1581