Skip to content

#837, option A#1671

Closed
kubukoz wants to merge 1 commit intoseries/0.18from
protocol-conflict-quickattempt
Closed

#837, option A#1671
kubukoz wants to merge 1 commit intoseries/0.18from
protocol-conflict-quickattempt

Conversation

@kubukoz
Copy link
Copy Markdown
Member

@kubukoz kubukoz commented Mar 31, 2025

Closes #837.

  • check if the protocol is already included (any version of it), before attempting to add our own from the local classpath.

Main problem: in case a lower version is included in the dependencies, the lower version will be picked for model loading - smithy4s's own fixes won't be taken into account, this could pose problems.


PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@kubukoz kubukoz changed the title Quick attempt at #837 #837, option A Mar 31, 2025
@kubukoz
Copy link
Copy Markdown
Member Author

kubukoz commented Apr 1, 2025

decided to go with option B #1672

@kubukoz kubukoz closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflicting traits in protocol dependency at codegen time

1 participant