Fix Long literal rendering to add L suffix#1898
Conversation
|
|
…oo large' Co-authored-by: kubukoz <894884+kubukoz@users.noreply.github.com>
L suffix
|
@copilot change one of the existing test values (in sampleSpecs/) so that it's too much for a normal integer, and regenerate the code. |
|
@copilot also update the CHANGELOG file to include this PR. The next release will be 0.18.49. |
Co-authored-by: kubukoz <894884+kubukoz@users.noreply.github.com>
Done in 2080a04. Changed |
Co-authored-by: kubukoz <894884+kubukoz@users.noreply.github.com>
|
@copilot add the missing CHANGELOG entry for 0.18.48 too |
Co-authored-by: kubukoz <894884+kubukoz@users.noreply.github.com>
Includes: - Long literal rendering fix (L suffix) from disneystreaming#1898 - Mill 1.x backport from disneystreaming#1899 - Codegen Scala 3 cross-compilation - Recursive scheme caching improvements Generated files kept as 0.19 (Hints.dynamic) variants; Long literal fix carried through Renderer merge.
Sync 0.18.48 and 0.18.49 changes into the 0.19 branch: - Long literal L suffix fix (disneystreaming#1898) - Dynamic number codegen update (disneystreaming#1886) - Type params for struct/union in codegen schemas (disneystreaming#1893) - Mill 1.x documentation update - Dependencies.Mima.core test dependency
When rendering integer number nodes as
Document.fromLong(...), the generated literal lacked theLsuffix, causing compilation failures (integer number too large) for values exceedingInt.MaxValue(e.g.1716459630).Changes
Renderer.scala: AppendLsuffix to generated long literalsDynamicHintRenderingSpecandAwsStandardTypesTransformerSpecupdated to match new outputsampleSpecs/numeric.smithy: Changed theLongfield default from1to9999999999(a value exceedingInt.MaxValue) to provide a concrete test case that validates the fix — without theLsuffix, this would fail to compilesbt bootstrapped/managedSourcesCHANGELOG.md: Added entries for the 0.18.48 and upcoming 0.18.49 releasesOriginal prompt
Longvalue - integer number too large #1897🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.