Integrate X3D JSON into loader so it can load either JSON or XML files#7
Open
coderextreme wants to merge 7 commits intodividab:masterfrom
Open
Integrate X3D JSON into loader so it can load either JSON or XML files#7coderextreme wants to merge 7 commits intodividab:masterfrom
coderextreme wants to merge 7 commits intodividab:masterfrom
Conversation
Contributor
|
Since this is a rather large PR it would be nice if you could provide a bullet point list in the main description of the PR summarising the changes that this PR will introduce. Also if you can add a motivation of why each of the changes were introduced that would be helpful when reviewing. Something like:
|
Contributor
|
I added a starting point for describing the PR in the main description. You can go ahead and edit this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add support for X3D JSON Encoding