Conversation
cjpatton
force-pushed
the
cjpatton/947-9-bt
branch
from
10dee90 to
a48dc65
Compare
cjpatton
force-pushed
the
cjpatton/947-9-bt
branch
from
a48dc65 to
fb75c23
Compare
divergentdave
approved these changes
Jan 16, 2025
cjpatton
force-pushed
the
cjpatton/947-8-cleanup
branch
from
cb024c4 to
871ef1c
Compare
This module was written for the Mastic VDAF. Mastic uses a binary tree in two ways: (1) path building from candidate prefixes; and (2) a breadth-first traversal for computing the evaluation proof. None of the functionalities implemented in the `bt` module support these operations efficiently. Instead, Mastic implements these operations directly. Remove the unused code from the `bt` module, leaving only the data types used by Mastic/VIDPF. It may be useful to keep these in their own module, as the data types may eventually be useful for Poplar1/IDPF.
cjpatton
force-pushed
the
cjpatton/947-9-bt
branch
from
fb75c23 to
5721bdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1187.
Partially addresses #947.
This module was written for the Mastic VDAF. Mastic uses a binary tree in two ways: (1) path building from candidate prefixes; and (2) a breadth-first traversal for computing the evaluation proof. None of the functionalities implemented in the
btmodule support these operations efficiently. Instead, Mastic implements these operations directly.Remove the unused code from the
btmodule, leaving only the data types used by Mastic/VIDPF. It may be useful to keep these in their own module, as the data types may eventually be useful for Poplar1/IDPF.