This repository was archived by the owner on May 23, 2020. It is now read-only.
move db creation file to delegated_dbhost#97
Open
oskapt wants to merge 1 commit intodj-wasabi:masterfrom
Open
Conversation
This change will retrieve the file used to initialize the database and then copy it to the `delegated_dbhost` before loading it. it intentionally does not remove the file afterward, in case something goes wrong and the file needs to be re-imported. it also only executes for the series of conditions around zabbix `>=3.0` and was only tested on Ubuntu. it resolves dj-wasabi#96.
Owner
|
Hi @oskapt The CI test failed with error: Could you please take a look at it? Thanks! |
Author
|
i have a local change that should fix this, but i'm unable to test it without building a new zabbix system for testing. how can i replicate your CI environment? i'd like to know that everything works before updating the PR. |
Owner
|
Install Molecule and do a |
Owner
|
How is it going? Do you need some help? Should I take a look at how to implement this and maybe add it to the molecule tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
This change will retrieve the file used to initialize the database and then copy it to the
delegated_dbhostbefore loading it. it intentionally does not remove the file afterward, in case something goes wrong and the file needs to be re-imported. it also only executes for the series of conditions around zabbix>=3.0and was only tested on Ubuntu.Type of change
Bugfix Pull Request
Fixes an issue
it fixes #96.