#336 bugfix from link_menu_item to modal_menu_item: discard changes link

[svandeneertwegh]

Description

The 'discard changes' link in the versioning menu item (toolbar) is with this PR changed from add_link_item to add_modal_item.

• [v ] I have opened this pull request against master
• I have added or modified the tests when changing logic
• I have followed the conventional commits guidelines to add meaningful information into the changelog
• I have read the contribution guidelines and I have joined #workgroup-pr-review on
  Slack to find a “pr review buddy” who is going to review my pull request.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dda7f5d) 90.86% compared to head (a0aafc7) 90.86%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files          72       72           
  Lines        2530     2530           
  Branches      356      356           
=======================================
  Hits         2299     2299           
  Misses        170      170           
  Partials       61       61           

Files	Coverage Δ
djangocms_versioning/cms_toolbars.py	96.90% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fsbraun]

@svandeneertwegh I have two observations:

• Upon confirming to discard changes, the modal does not close. Instead, the version list of the object is shown in the modal. I think the modal would need to close, and the page should probably redirect to the preview of the published version.
• It seems to me that the draft version actually is not discarded. I am not sure why. But it appears to stay in the version list shown in the modal.