ci: fix tests running

[vinitkumar]

Description

Related resources

• #...
• #...

Checklist

• I have opened this pull request against master
• I have added or modified the tests when changing logic
• I have followed the conventional commits guidelines to add meaningful information into the changelog
• I have read the contribution guidelines and I have joined #workgroup-pr-review on
  Slack to find a “pr review buddy” who is going to review my pull request.

[fsbraun]

@vinitkumar It seems the compiled test requirements do not contain a pinned version of django CMS and the tests always install the latest django CMS 4. I guess the compilescript needs an update to include the django-cms version.

@marksweb I am not sure it is a good idea to pin the installed versions for tests. We miss incompatibilities from changes in libraries after the compile time. What do you think?

[marksweb]

@fsbraun do you specifically mean pinning cms?

[fsbraun]

@marksweb The requirements.in did not include django-cms and hence the compile.py did not pin the django-cms version in the compiled requirements (e.g., missing here). Since the package itself depends on django-cms, the latest django-cms was installed for each of the tests letting them fail (since the tests do not run on django CMS 4 yet).

I've added django-cms to requirements.in to let the tests run against the specified django-cms version.

But my question was a different one: I would prefer not to compile the requirements for tests to always run against the latest dependencies. Otherwise, we will not notice incompatibilities introduced in new releases of dependencies after the compile time. Am I missing something?

[marksweb]

@fsbraun you're probably not missing anything but this was a pattern I picked up from Adam Johnson. And I quite like how easy it makes updating and maintaining requirements. I get the point about missing new releases. But maybe we can script /automate the updating of requirements a bit like how dependant can. Or maybe the requirements themselves can be more broad and just be greater than a given version.

[fsbraun]

@vinitkumar Does it make sense to update this?

[vinitkumar]

@fsbraun I totally forgot about this. Let me have a look into this.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.