Fix PostgreSQL compatibility issues in CI and SQL profiling #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes django-commons#2185 - Add vendor detection to SQL panel profiling to prevent MySQL-specific commands on PostgreSQL - Fix CI PostgreSQL job environment variables - Fix malformed lint job strategy configuration - Add comprehensive PostgreSQL compatibility tests Changes: - debug_toolbar/panels/sql/forms.py: Add vendor check in profile() method - .github/workflows/test.yml: Add DB_* env vars for PostgreSQL, fix lint job - tests/test_postgresql_compatibility.py: New test file for PostgreSQL fixes - docs/changes.rst: Document PostgreSQL compatibility improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes PostgreSQL compatibility issues that were causing CI pipeline failures. The main issue was that the SQL panel's profiling feature was attempting to use MySQL-specific commands on PostgreSQL databases, resulting in errors like "unrecognized configuration parameter profiling".
Additionally, the CI configuration had missing environment variables for PostgreSQL test jobs and a malformed lint job configuration.
Key Changes:
Root Cause: The
SQLSelectForm.profile()method was executing MySQL-specificSET PROFILINGcommands and queryinginformation_schema.profilingwithout checking the database vendor, causing PostgreSQL CI jobs to fail.Solution: Added vendor detection that raises a clear
ValueErrorfor non-MySQL databases, preventing the MySQL-specific code from executing on PostgreSQL/SQLite.Fixes #2185
Checklist:
docs/changes.rst.