Skip to content

Conversation

federicobond
Copy link
Contributor

Description

This adds a setting to configure an Open in editor URL when you click on a template path. Makes it easier to jump directly to the template and edit. Can develop it further and/or add tests if there is interest in the feature.

Captura de pantalla 2025-09-13 a la(s) 23 04 38

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's possible to detect that the project is running in vscode and we could avoid the setting altogether?

@tim-schilling
Copy link
Member

Ah, that's a good reference. I like the idea of having a magic-ish value/constant to specify rather than asking them to write in a lambda for a setting.

@federicobond federicobond force-pushed the open-in-editor branch 2 times, most recently from 33d4005 to 99f0190 Compare October 7, 2025 04:23
@federicobond
Copy link
Contributor Author

@tim-schilling updated to use a constant to specify the editor URL format.

Test failures appear unrelated.

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Marking it as Request Changes to ask for the tests. I think tests that cover get_editor_url and the new get_stats() of TemplatesPanel would be great.

The other stretch thing would be to add is a reference to the new setting in the TemplatesPanel documentation.

@federicobond
Copy link
Contributor Author

I just added the requested tests and updated the docs format.

I would prefer to hold off with documenting this as something that's mostly useful for the requests panel because I believe it's going to be useful in other places too (like stacktraces).

@tim-schilling
Copy link
Member

That's fair about mentioning the editor setting the templates panel documentation. I think we do want to have this mentioned in the changes.rst file so folks get alerted to the change in the next release.

@federicobond
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants