Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s optional properties extra to require enum-properties>=2.5.1, addressing issue #146 where enum.auto() failed for enums derived from django_enum.choices.TextChoices.
Changes:
- Bump the minimum
enum-propertiesversion for thepropertiesoptional dependency to>=2.5.1. - Add a regression test covering
auto()behavior forTextChoices, including_generate_next_value_override behavior.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Raises the minimum enum-properties version for the properties extra to ensure auto() works with Choices-derived enums. |
tests/test_auto.py |
Adds regression coverage for auto() with django_enum.choices.TextChoices, including label and extra property handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| self.assertEqual(MyTextChoices.BAR.custom_value, "bar123") | ||
|
|
||
| class MyTextChoicesAutoOverride(TextChoices): | ||
| def _generate_next_value_(name, start, count, last_values): |
There was a problem hiding this comment.
Normal methods should have 'self', rather than 'name', as their first parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #146