Skip to content

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Oct 8, 2025

This PR adds Django 6.0 compatibility and updates the test matrix.

The key change is that a model's _do_update method requires a 7th positional parameter returning_fields.

charettes/django@55a0073

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
django_fsm/__init__.py 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
django_fsm/__init__.py 94.88% <80.00%> (-0.28%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

=========

Unreleased
django-fsm-2 4.1.0 unreleased
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure yet if it will be released as 4.1 or 5.0 (if we manage to include the admin PR)

Suggested change
django-fsm-2 4.1.0 unreleased
django-fsm-2 unreleased

Copy link
Member

@pfouque pfouque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
I will merge it despite codecov complaining about the coverage! ;)

@pfouque pfouque merged commit de01127 into django-commons:main Oct 8, 2025
9 of 10 checks passed
@fsbraun
Copy link
Member Author

fsbraun commented Oct 8, 2025

@pfouque Thanks! The missing coverage line must be spurious. I'm not sure why (aggregation?).

The line claimed uncovered makes the tests pass for Django 6. Maybe there's something with the coverage config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants