add historic one to one field #1265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1265 +/- ##
==========================================
+ Coverage 96.94% 96.96% +0.02%
==========================================
Files 23 23
Lines 1277 1287 +10
Branches 210 210
==========================================
+ Hits 1238 1248 +10
Misses 21 21
Partials 18 18 ☔ View full report in Codecov by Sentry. |
ddabble
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Without having taken the time to examine this, I can personally not confidently say that this code would work - especially considering how a previous suggestion trying to implement it was considerably longer (see #1031 (comment)) - so could you provide some tests for this? 🙂
|
Closing in favor of #1394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add historic one to one field