fix: catch correct DoesNotExist in HistoricReverseOneToOneDescriptor.…#1590
Open
awais786 wants to merge 1 commit intodjango-commons:masterfrom
Open
fix: catch correct DoesNotExist in HistoricReverseOneToOneDescriptor.…#1590awais786 wants to merge 1 commit intodjango-commons:masterfrom
awais786 wants to merge 1 commit intodjango-commons:masterfrom
Conversation
…__get__ Closes django-commons#1588 Django's ReverseOneToOneDescriptor.__get__ catches self.related.related_model.DoesNotExist, but when HistoricDescriptorMixin.get_queryset() returns a queryset over the historical model (e.g. HistoricalB instead of B), only the historical model's DoesNotExist matches. Override __get__ in HistoricReverseOneToOneDescriptor to catch queryset.model.DoesNotExist so that hasattr/getattr on a missing reverse OneToOne returns False/None instead of raising. Adds a regression test to HistoricOneToOneFieldTest covering the missing-relation case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1588
Django's ReverseOneToOneDescriptor.get catches self.related.related_model.DoesNotExist, but when HistoricDescriptorMixin.get_queryset() returns a queryset over the historical model (e.g. HistoricalB instead of B), only the historical model's DoesNotExist matches. Override get in HistoricReverseOneToOneDescriptor to catch queryset.model.DoesNotExist so that hasattr/getattr on a missing reverse OneToOne returns False/None instead of raising.
Adds a regression test to HistoricOneToOneFieldTest covering the missing-relation case.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst