Skip to content

feat:add job-class kwarg to rqworker #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2024
Merged

feat:add job-class kwarg to rqworker #160

merged 3 commits into from
Sep 14, 2024

Conversation

gabriels1234
Copy link
Contributor

Fixes #159

@gabriels1234
Copy link
Contributor Author

@cunla I have added both a test for when --job-class is used and for when it's not used, ensuring proper behavior for both current django-tasks-scheduler users and also for those coming from django-rq-scheduler.
Would you like me to follow a different approach? like allowing any Job type, as a responsibility of the user?
In my case, I updated my CustomJob to inherit from JobExecution instead of rq.job.Job.

@gabriels1234
Copy link
Contributor Author

@cunla please let me know if I can be of help.
Thanks!!

@cunla cunla merged commit 8a09f51 into django-commons:master Sep 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cunla cunla cunla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Custom job class (--job-class) to rqworker
2 participants
@gabriels1234 @cunla