Skip to content

[ci] - Add Ruff formatting step to CI pipeline #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2025
Merged

[ci] - Add Ruff formatting step to CI pipeline #312

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46645d4
[ci] - Add Ruff formatting step to CI pipeline
DhavalGojiya Oct 13, 2025
6f94859
[refactor] - Simplify the Ruff format command in the CI pipeline
DhavalGojiya Oct 13, 2025
2017df0
Apply suggestion from @cclauss
cclauss Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,19 @@ jobs:
- uses: actions/checkout@v5
with:
persist-credentials: false

- name: Run Ruff Linting 🧹
uses: astral-sh/ruff-action@v3
with:
args: check
src: "."

- name: Run Ruff Formatting 🧽
uses: astral-sh/ruff-action@v3
with:
args: "format --check"
src: "."

test-regular:
needs: ["ruff", "uv-lock-check"]
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions scheduler/tests/test_task_types/test_task_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def test_parse_kwargs(self):
taskarg_factory(TaskKwarg, key="key3", arg_type="bool", val=True, content_object=task)
taskarg_factory(TaskKwarg, key="key4", arg_type="datetime", val=date, content_object=task)
kwargs = task.parse_kwargs()
self.assertEqual(kwargs, {'key1': "one", 'key2': 2, 'key3': True, 'key4': date})
self.assertEqual(kwargs, {"key1": "one", "key2": 2, "key3": True, "key4": date})

def test_callable_args_and_kwargs(self):
task = task_factory(self.task_type, callable="scheduler.tests.jobs.test_args_kwargs")
Expand Down Expand Up @@ -418,7 +418,7 @@ def test_admin_single_delete(self):
self.assertTrue(task.is_scheduled())
prev_executions_count = len(_get_executions(task))
url = reverse("admin:scheduler_task_delete", args=[task.pk])
data = {'post': "yes"}
data = {"post": "yes"}
# act
res = self.client.post(url, data=data, follow=True)
# assert
Expand Down
Loading