Skip to content

Reapply "Add Creativeklvn to django-commons (#258)"#263

Merged
tim-schilling merged 1 commit intomainfrom
add-creativeklvn
Sep 6, 2025
Merged

Reapply "Add Creativeklvn to django-commons (#258)"#263
tim-schilling merged 1 commit intomainfrom
add-creativeklvn

Conversation

@tim-schilling
Copy link
Copy Markdown
Member

@tim-schilling tim-schilling commented Sep 6, 2025

This reverts commit ab3f8ed.

@ryancheley I reverted the last commit, let the plan be applied then merged. Then reverted, the revert (reapplying the original commit).

The problem was that the merge commit changed the plan from what was on the PR. I'm going to disable merge commits on the repo to avoid this in the future. That's already done. It was the "update branch with merge" that may have been the problem.

@tim-schilling tim-schilling requested a review from a team as a code owner September 6, 2025 03:16
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 6, 2025

Terraform plan in terraform
With var files: terraform/production/org.tfvars terraform/production/repositories.tfvars
With variables: github_token = (sensitive value)

Plan: 2 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # github_membership.this["Creativeklvn"] will be created
+   resource "github_membership" "this" {
+       downgrade_on_destroy = false
+       etag                 = (known after apply)
+       id                   = (known after apply)
+       role                 = "member"
+       username             = "Creativeklvn"
    }

  # github_membership.this["adamghill"] will be created
+   resource "github_membership" "this" {
+       downgrade_on_destroy = false
+       etag                 = (known after apply)
+       id                   = (known after apply)
+       role                 = "member"
+       username             = "adamghill"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

📝 Plan generated in Plan org changes and list them in a PR #138

@tim-schilling tim-schilling merged commit 19647ff into main Sep 6, 2025
3 checks passed
@tim-schilling tim-schilling deleted the add-creativeklvn branch September 6, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant