Skip to content

use user.pk instead of user.id #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

use user.pk instead of user.id #1445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1412fb3
use user.pk instead of user.id
sahama Jul 30, 2024
e50c58b
update AUTHORS and CHANGELOG
sahama Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ Rustem Saiargaliev
Sandro Rodrigues
Shaheed Haque
Shaun Stanworth
Sayyid Hamid Mahdavi
Silvano Cerza
Sora Yanai
Spencer Carroll
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* #1425 Remove deprecated `RedirectURIValidator`, `WildcardSet` per #1345; `validate_logout_request` per #1274

### Fixed
* fix user pk in creating OIDC JWT token
### Security

## [2.4.0] - 2024-05-13
Expand Down
4 changes: 2 additions & 2 deletions oauth2_provider/oauth2_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,9 +792,9 @@ def get_jwt_bearer_token(self, token, token_handler, request):

def get_claim_dict(self, request):
if self._get_additional_claims_is_request_agnostic():
claims = {"sub": lambda r: str(r.user.id)}
claims = {"sub": lambda r: str(r.user.pk)}
else:
claims = {"sub": str(request.user.id)}
claims = {"sub": str(request.user.pk)}

# https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims
if self._get_additional_claims_is_request_agnostic():
Expand Down
Loading