Skip to content

modernize packaging using pyproject.toml #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Aug 15, 2024

Description of the Change

This PR modernizes packaging using pyproject.toml instead of setup.py. See https://packaging.python.org/en/latest/guides/modernize-setup-py-project/

You can test the change using below command

tox -e build

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk added this to the 3.0.0 milestone Aug 15, 2024
@n2ygk
Copy link
Contributor

n2ygk commented Aug 15, 2024

We need to think hard about this since the package builds and twine uploads to pypi are somehow automated by jazzband magic.

@dulmandakh
Copy link
Contributor Author

python -m build output artifact is same with python setup.py sdist --format=gztar bdist_wheel, thus twine check works as expected. IMHO, there won't be any change in package publishing, please see https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot. We'll find out soon enough if there's issues with Jazzband's scripts that push to pypi.

@n2ygk n2ygk merged commit 9fceef1 into django-oauth:master Aug 15, 2024
20 checks passed
@dulmandakh dulmandakh deleted the pyproject branch August 15, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants