-
Notifications
You must be signed in to change notification settings - Fork 220
Add a test to check for missing migrations in test app models. #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test to check for missing migrations in test app models. #213
Conversation
|
Excellent! I’m on my phone right now but I’ll take a closer look when I’m back on the PC. I see mssql tests failed? That seems odd |
|
MySQL failures seem unrelated - maybe just need to restart those builds (I don't seem to have permission to do that)? |
|
It just failed the tests for MSSQL again. Don't know much about them, but it's the second time this PR makes them fail. I don't know much about SQL Server, and even less about Django connecting to it, but if we are supporting it now, we need to sort this out. |
|
MSSQL failures are because |
|
Oh! Can we disable those tests until that's dealt with then? |
|
@tabo yes - I've commented those out of the appveyor config for now. Build should pass this time. |
This will hopefully flag changes to the Treebeard models that require a migration, to ensure that such changes are (a) evaluated for their necessity and (b) shipped as part of a major release.
|
A general comment on MSSQL - Django itself does not support MSSQL, and there really isn't a robust third-party backend available. I don't think Treebeard can actually guarantee that it will work on MSSQL - and on that basis don't think we should declare support for it. |
|
@solarissmoke Fantastic work on this PR. Thanks! And you make a fair point on MSSQL support, but if the tests are working with it, then it's safe to say that treebeard will work on it. My only concern is having 2 test infra and how slow those MSSQL tests are. |
|
@tabo it should be possible to move these tests to Github actions (thus we can drop both Travis and AppVeyor) - I will have a play with that when I have some more time. |
This will hopefully flag changes to the Treebeard models that
require a migration, to ensure that such changes are (a) evaluated for
their necessity and (b) shipped as part of a major release.
See #212 .