Add port option for ChannelsLiveServerTestCase#2136
Closed
MohammedSaleh2001 wants to merge 0 commit intodjango:mainfrom
Closed
Add port option for ChannelsLiveServerTestCase#2136MohammedSaleh2001 wants to merge 0 commit intodjango:mainfrom
MohammedSaleh2001 wants to merge 0 commit intodjango:mainfrom
Conversation
Member
carltongibson
left a comment
carltongibson
left a comment
There was a problem hiding this comment.
Hi @MohammedSaleh2001 — thanks for this.
I think at the least, we should document the new feature in the testing docs...
https://channels.readthedocs.io/en/latest/topics/testing.html#serve-static
Otherwise no-one will ever know about it.
MohammedSaleh2001
force-pushed
the
main
branch
from
29f917a to
2265bd0
Compare
Author
|
Hi, I've updated the documentation. If it needs more detail let me know, thanks. Also, is the Daphne PR okay? I didn't see any documentation to update there. |
Member
|
@MohammedSaleh2001 The DaphneProcess is internal. (No need for docs there) |
Author
|
Thanks for letting me know. I also fixed the line length, hopefully that will suffice. |
Member
|
@MohammedSaleh2001 Sorry I broke this PR rebasing. Carried on in #2173. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes based on https://github.com/django/channels/discussions/2135
Add an accessible port attribute for the ChannelsLiveServerTestCase class. Since it is supposed to be externally accessible now, I removed the internal indicator.
This depends on changes to DaphneProcess in another pull request I've made to that repository: https://github.com/django/daphne/pull/550