Skip to content

FEAT: type hint #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

FEAT: type hint #417

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4da1969
FEAT: type hint
iwakitakuma33 May 28, 2025
21ff64d
FIX REVIEW
iwakitakuma33 May 29, 2025
10b4a42
FIX: order import
iwakitakuma33 Jun 9, 2025
1e3e55d
TEST
iwakitakuma33 Jun 9, 2025
09e71cb
Merge branch 'main' into feat/type_hint
iwakitakuma33 Jul 26, 2025
0052136
CHORE: mypy deps
iwakitakuma33 Jul 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tox.ini
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why commit this?
this already exists in the code base

Copy link
Author

@iwakitakuma33 iwakitakuma33 Jul 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirreza8002
#417 (comment)

This is because it is necessary to check the type using ci based on the review from bigfootjon.

black flake8 isort cannot detect type hint inconsistencies.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was misguided by how GitHub showed this
i saw a different thing
sorry about that

tip: don't merge main branches into your pr, you usually want to rebase

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirreza8002 Thank you for your confirmation!

Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ commands =
pytest -v {posargs}
mypy --config-file=tox.ini channels_redis
deps =
mypy>=1.9.0
ch30: channels>=3.0,<3.1
ch40: channels>=4.0,<4.1
ch4: channels>=4.0,<5
chmain: https://github.com/django/channels/archive/main.tar.gz
redis5: redis>=5.0,<6
redis6: redis>=6.0,<7
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.