Open
Conversation
sarahboyce
reviewed
Mar 25, 2024
sarahboyce
approved these changes
Mar 29, 2024
Collaborator
sarahboyce
left a comment
sarahboyce
left a comment
There was a problem hiding this comment.
LGTM
@smithdc1 maybe you can review also 🙏
smithdc1
reviewed
Mar 30, 2024
Member
smithdc1
left a comment
smithdc1
left a comment
There was a problem hiding this comment.
Hi all a few questions below. My main concern is how much work is being done by the random_*() methods vs what we're actually trying to benchmark. We can test for that using asv profile and if significant we should look to move that effort outside of the benchmark.
| from ...utils import bench_setup | ||
|
|
||
|
|
||
| class DatabaseCacheBackend: |
Member
There was a problem hiding this comment.
Do you think we could add coverage for the some of the other backends too? The benchmarks would be the same, it's just a different setting? 🤔
Author
There was a problem hiding this comment.
Can we do this in separate pull request?
roelzkie15
pushed a commit
to roelzkie15/django-asv
that referenced
this pull request
Jul 24, 2025
…tion using different password hasher. This is related to django/pull/81
roelzkie15
added a commit
to roelzkie15/django-asv
that referenced
this pull request
Jul 24, 2025
…tion using different password hasher. This is related to django/pull/81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds database cache benchmarks as requested by @sarahboyce here
After running on these commits and one local commit showing improved set_many
I get these graphs:
